Dismiss the Debug Console incorrectly and it terminates Everything

Discussion related to "Everything" 1.5 Alpha.
Post Reply
raccoon
Posts: 1017
Joined: Thu Oct 18, 2018 1:24 am

Dismiss the Debug Console incorrectly and it terminates Everything

Post by raccoon »

Opening the Tools -> Debug -> Console [Ctrl+Shift+J] will open a ConsoleWindowClass which cannot be closed from system menu or caption close button. It can only be closed again by another visit to Tools -> Debug -> Console or Ctrl+Shift+J while the main window is active.

However, you can still close the debug console window from the Taskbar Thumbnail Preview caption close button. This causes Everything to hard terminate without saving session data, ie, search history is lost.

Any way to make closing the debug console more graceful and convenient?
NotNull
Posts: 5461
Joined: Wed May 24, 2017 9:22 pm

Re: Dismiss the Debug Console incorrectly and it terminates Everything

Post by NotNull »

It has been discussed. Bottom line: not without a lot of effort and rewriting.

Instead, I would like to suggest a DEBUG text entry in the status bar. Double-clicking on DEBUG would close it.
void
Developer
Posts: 16771
Joined: Fri Oct 16, 2009 11:31 pm

Re: Dismiss the Debug Console incorrectly and it terminates Everything

Post by void »

The debug console lives in a completely different process which I have limited control over.

csrss.exe hosts the debug console.

You can still use the debug console when the main Everything.exe process dies.



There's no API to intercept the close button press. (only to receive a notification via SetConsoleCtrlHandler)


Everything 1.5 disables the close button to prevent the accidental termination.
You can still use Ctrl + C in the console to terminate Everything.

I have on my TODO list to create my own console window.

Instead, I would like to suggest a DEBUG text entry in the status bar. Double-clicking on DEBUG would close it.
I have put this on my TODO list.

Thanks for the suggestions.
raccoon
Posts: 1017
Joined: Thu Oct 18, 2018 1:24 am

Re: Dismiss the Debug Console incorrectly and it terminates Everything

Post by raccoon »

Thanks for the replies, but I'm still a little unclear why this should crash Everything. What makes the Everything process critically dependent on the console window that it vomits when the console window closes unexpectedly and without approval?
void
Developer
Posts: 16771
Joined: Fri Oct 16, 2009 11:31 pm

Re: Dismiss the Debug Console incorrectly and it terminates Everything

Post by void »

Closing the console will terminate the Everything process.

This is normal behavior of the Windows Console and cannot be changed easily.


In Debug mode, Everything will essentially run as a 'console program'.
Closing the console terminates the program.
Post Reply