problem with undo

Discussion related to "Everything" 1.5 Alpha.
Post Reply
295126748
Posts: 29
Joined: Sun Mar 22, 2020 6:44 am

problem with undo

Post by 295126748 »

hello,something may be problem:

in everyhing search result---choose the file desktop\1\1.txt

do not use "cut" or "advanced move to folder" in the menu of everything

instead,just CTRL+X and CTRT+V

or user right click (in result list)


to move desktop\1\1.txt to desktop\2\ (also in result list)

but windows say in desktop\2\

there is a 1.txt with the same name

and i choose rename 1.txt to 1(2).txt

and then

i user undo of everyhing

and wrong file was cut to wrong place by undo.

------------
CTRL+C and CTRT+V also have similar situation (will delete wrong file)
void
Developer
Posts: 16773
Joined: Fri Oct 16, 2009 11:31 pm

Re: problem with undo

Post by void »

Thank you for your feedback 295126748,

Unfortunately, this is a limitation with Everything.
Everything pastes files with the paste verb.

There is no feedback when pasting an item with the paste verb.
This means Everything doesn't know if the paste was successful, cancelled or even if the pasted filename was renamed by the OS.



For the next alpha update, Everything will not add an undo entry for items where the target filename already exists.
You can undo these operations from Windows Explorer.



I would like to continue using the paste verb for the following reasons:
Support for third party tools that hook the paste verb.
Conflict resolution dialogs provided by the standard Windows Shell.

An alternative is IFileOperation, which I don't see a lot of support for in third party tools and this doesn't handle renaming when there is a filename conflict.
On a side note, pasting into multiple folders uses IFileOperation.
Everything is provided feedback from IFileOperation for undo operations.
I have on my TODO list is to handle pasting myself with IFileOperations.
harryray2
Posts: 1104
Joined: Sat Oct 15, 2016 9:56 am

Re: problem with undo

Post by harryray2 »

For the next alpha update, Everything will not add an undo entry for items where the target filename already exists.
Will it be possible to disable this and keep on the undo list?
therube
Posts: 4985
Joined: Thu Sep 03, 2009 6:48 pm

Re: problem with undo

Post by therube »

The only change to Undo list is that the invalid entry (caused in the situation described) will not be logged.
void
Developer
Posts: 16773
Joined: Fri Oct 16, 2009 11:31 pm

Re: problem with undo

Post by void »

Everything 1.5.0.1310a improves undo operations when pasting.

Everything will no longer add an undo operation when there is a filename conflict when pasting.



To add an undo operation for conflicting filenames when pasting:
  • In Everything, type in the following search and press ENTER:
    /paste_undo_conflict=1
  • If successful, paste_undo_conflict=1 is shown in the status bar for a few seconds.
harryray2
Posts: 1104
Joined: Sat Oct 15, 2016 9:56 am

Re: problem with undo

Post by harryray2 »

Thanks for paste_undo_conflict...I need undo to show all items...
295126748
Posts: 29
Joined: Sun Mar 22, 2020 6:44 am

Re: problem with undo

Post by 295126748 »

void wrote: Thu Apr 21, 2022 7:06 am Everything 1.5.0.1310a improves undo operations when pasting.

Everything will no longer add an undo operation when there is a filename conflict when pasting.



To add an undo operation for conflicting filenames when pasting:
  • In Everything, type in the following search and press ENTER:
    /paste_undo_conflict=1
  • If successful, paste_undo_conflict=1 is shown in the status bar for a few seconds.
I have use the latest build and find drag and drop to move file still have the undo with the same filename
void
Developer
Posts: 16773
Joined: Fri Oct 16, 2009 11:31 pm

Re: problem with undo

Post by void »

Everything only sees drag dropped files as moved/copied.

How are you drag dropping a file so the filename ends up with a different basename?
-Are you using a third party tool to handle drag-drop moves?
295126748
Posts: 29
Joined: Sun Mar 22, 2020 6:44 am

Re: problem with undo

Post by 295126748 »

void wrote: Thu Apr 28, 2022 10:55 am Everything only sees drag dropped files as moved/copied.

How are you drag dropping a file so the filename ends up with a different basename?
-Are you using a third party tool to handle drag-drop moves?
:? I mean 1310 improve the situation with ctrl+x but without drag-drop.

if a folder has a file with conflict filename 123123.txt

and I drag-drop another file which has same name 123123.txt to this folder ,and windows say there is a file with same name ,and I choose the third option to rename it to 123123(2).txt,and Everything's undo system will make mistake .

just like what I described at viewtopic.php?f=12&t=11416#top

the difference is not using ctrl+x but drag-drop.
void
Developer
Posts: 16773
Joined: Fri Oct 16, 2009 11:31 pm

Re: problem with undo

Post by void »

Thanks for clarifying 295126748,

The next alpha update of Everything will not add an undo operation when the target filename already exists from a drag-drop move/copy.

The OS does the move/copy.
There is no information provided from the OS about a renamed file in a move/copy.

Everything currently assume there was no conflicting filename in the move/copy operation.


Move/Copy actions can be undone from Windows Explorer when the operation contained a conflicting filename.


I will look into methods to detect a renamed file in a move/copy or using my own move/copy operations.
harryray2
Posts: 1104
Joined: Sat Oct 15, 2016 9:56 am

Re: problem with undo

Post by harryray2 »

More or less the same question as I posted previously, regarding a preference to disable this and show files that are moved/copied on undo list.



Thanks.
void
Developer
Posts: 16773
Joined: Fri Oct 16, 2009 11:31 pm

Re: problem with undo

Post by void »

The same paste_undo_conflict setting will be able to disable this.
harryray2
Posts: 1104
Joined: Sat Oct 15, 2016 9:56 am

Re: problem with undo

Post by harryray2 »

Great, thank you.
Post Reply